Brettle Development

The UploadHttpModule seems to be handling requests even on non configured URL.
On each registered event, there should be a:
if (!Config.Current.UseHttpModule)
{
    return;
}
as there is in Application_BeginRequest.

Otherwise, using Server.Transfer(url, true) on a non configured url cleans the Form collection.

Alberto Bolchini (albertob at engitel.com)

Here's a patch:

--- NeatUpload-trunk.412.orig/UploadHttpModule.cs    2006-09-26 01:25:26.000000000 +0200
+++ NeatUpload-trunk.412/UploadHttpModule.cs    2006-11-15 10:15:26.328125000 +0100
@@ -330,6 +330,10 @@
 
         private void Application_ResolveRequestCache(object sender, EventArgs e)
         {
+            if (!Config.Current.UseHttpModule)
+            {
+                return;
+            }
             if (log.IsDebugEnabled) log.Debug("In Application_ResolveRequestCache");
             // Wait for the upload to complete before AcquireRequestState fires.  If we don't then the session
             // will be locked while the upload completes
@@ -361,6 +365,10 @@
 
         private void Application_PreSendRequestHeaders(object sender, EventArgs e)
         {
+            if (!Config.Current.UseHttpModule)
+            {
+                return;
+            }
             if (log.IsDebugEnabled) log.Debug("In Application_PreSendRequestHeaders");
             if (requestHandledBySubRequest)
             {
@@ -389,6 +397,10 @@
 
         private void Application_Error(object sender, EventArgs e)
         {
+            if (!Config.Current.UseHttpModule)
+            {
+                return;
+            }
             if (log.IsDebugEnabled) log.Debug("In Application_Error");
             HttpApplication app = sender as HttpApplication;
             if (log.IsDebugEnabled) log.DebugFormat("Error is: {0}", app.Server.GetLastError());
@@ -403,6 +415,10 @@
         private EventHandler RememberErrorHandler;
         private void RememberError(object sender, EventArgs e)
         {
+            if (!Config.Current.UseHttpModule)
+            {
+                return;
+            }
             DecoratedWorkerRequest decoratedWorker = GetCurrentWorkerRequest() as DecoratedWorkerRequest;
             HttpApplication app = sender as HttpApplication;
            
@@ -428,8 +444,11 @@
 
         private void Application_EndRequest(object sender, EventArgs e)
         {
+            if (!Config.Current.UseHttpModule)
+            {
+                return;
+            }
             if (log.IsDebugEnabled) log.Debug("In Application_EndRequest");
-
             HttpApplication app = sender as HttpApplication;
             if (RememberErrorHandler != null)
             {

Yes, the check on all methods actually fixed the behaviour.

I have an httphandler which transfers /aaa/bbb/ccc.html to /xxx/yyy/zzz.aspx?id=123 with a Server.Transfer(url, true). zzz.aspx gets the server variable "QUERY_STRING" correct (id=123) but the Request parameters collection gets cleaned.

I'm using .NET 1.1.4322 on Windows XP with NeatUpload-trunk.412

Thank you,

Alberto.

The fix in NeatUpload-trunk.415 introduced another bug that occurs when the URL that the form is posted to does not contain a query string.  That is fixed as of NeatUpload-trunk.417.

--Dean